# \[PATCH net-next v2 0/6\]\[pull request\] ice: add support for devlink health events

- From: Tony Nguyen \<anthony.l.nguyen@intel.com\>
- Date: 2024-12-17 21:08:48 
- List: netdev
- Page: https://ratatoskr.run/netdev/2024/12/11314082
- Thread: https://ratatoskr.run/netdev/2024/12/11314082/t.md

```text
Przemek Kitszel says:

Reports for two kinds of events are implemented, Malicious Driver
Detection (MDD) and Tx hang.

Patches 1, 2, 3: core improvements (checkpatch.pl, devlink extension)
Patch 4: rename current ice devlink/ files
Patches 5, 6, 7: ice devlink health infra + reporters

Mateusz did good job caring for this series, and hardening the code.
---
v2:
- dropped ethtool stats dumping (Kuba), what resulted in Tx hang reporter
  patches to be squashed into one
- collected Joe's Ack, and Kalesh's RB

v1: https://lore.kernel.org/netdev/20241211223231.397203-1-anthony.l.nguyen@intel.com

IWL: https://lore.kernel.org/intel-wired-lan/20240930133724.610512-1-przemyslaw.kitszel@intel.com/

with patches squashed in:
https://lore.kernel.org/intel-wired-lan/20241210115620.3141094-1-mateusz.polchlopek@intel.com/
https://lore.kernel.org/intel-wired-lan/20241203082753.4831-2-przemyslaw.kitszel@intel.com/

The following are changes since commit d22f955cc2cb9684dd45396f974101f288869485:
  rust: net::phy scope ThisModule usage in the module_phy_driver macro
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 100GbE

Ben Shelton (1):
  ice: Add MDD logging via devlink health

Mateusz Polchlopek (1):
  devlink: add devlink_fmsg_dump_skb() function

Przemek Kitszel (4):
  checkpatch: don't complain on _Generic() use
  devlink: add devlink_fmsg_put() macro
  ice: rename devlink_port.[ch] to port.[ch]
  ice: add Tx hang devlink health reporter

 drivers/net/ethernet/intel/ice/Makefile       |   3 +-
 .../net/ethernet/intel/ice/devlink/devlink.c  |   2 +-
 .../net/ethernet/intel/ice/devlink/health.c   | 269 ++++++++++++++++++
 .../net/ethernet/intel/ice/devlink/health.h   |  58 ++++
 .../ice/devlink/{devlink_port.c => port.c}    |   2 +-
 .../ice/devlink/{devlink_port.h => port.h}    |   0
 drivers/net/ethernet/intel/ice/ice.h          |   2 +
 drivers/net/ethernet/intel/ice/ice_eswitch.h  |   2 +-
 drivers/net/ethernet/intel/ice/ice_main.c     |  26 +-
 drivers/net/ethernet/intel/ice/ice_repr.c     |   2 +-
 drivers/net/ethernet/intel/ice/ice_sf_eth.c   |   2 +-
 include/net/devlink.h                         |  13 +
 net/devlink/health.c                          |  67 +++++
 scripts/checkpatch.pl                         |   2 +
 14 files changed, 438 insertions(+), 12 deletions(-)
 create mode 100644 drivers/net/ethernet/intel/ice/devlink/health.c
 create mode 100644 drivers/net/ethernet/intel/ice/devlink/health.h
 rename drivers/net/ethernet/intel/ice/devlink/{devlink_port.c => port.c} (99%)
 rename drivers/net/ethernet/intel/ice/devlink/{devlink_port.h => port.h} (100%)

-- 
2.47.1

```
