RE: [PATCH net-next 1/4] net: stmmac: dwmac4: Fix MTL_OP_MODE_RTC mask and shift macros
From: Leyfoon Tan <hidden>
Date: 2024-10-16 06:59:57
Also in:
lkml
From: Leyfoon Tan <hidden>
Date: 2024-10-16 06:59:57
Also in:
lkml
-----Original Message----- From: Jakub Kicinski <kuba@kernel.org> Sent: Wednesday, October 16, 2024 10:10 AM To: Leyfoon Tan <redacted> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>; Jose Abreu [off-list ref]; David S . Miller [off-list ref]; Eric Dumazet [off-list ref]; Paolo Abeni [off-list ref]; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; lftan.linux@gmai.com Subject: Re: [PATCH net-next 1/4] net: stmmac: dwmac4: Fix MTL_OP_MODE_RTC mask and shift macros On Tue, 15 Oct 2024 14:57:05 +0800 Ley Foon Tan wrote:quoted
RTC fields are located in bits [1:0]. Correct the _MASK and _SHIFT macros to use the appropriate mask and shift. Fixes: 35f74c0c5dce ("stmmac: add GMAC4 DMA/CORE Header File") Signed-off-by: Ley Foon Tan <redacted>no empty line between Fixes and Signed-off-by lines, please. Please fix and resend with [PATCH net] in the title. All fixes which are needed in current Linus's tree need to go to net, rather than net-next, see: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#git- trees-and-patch-flow -- pw-bot: cr
Noted, will resend. Thanks. Regards Ley Foon