[PATCH net-next 1/2] tty: Add N_TASHTALK line discipline for TashTalk Localtalk serial driver

Subsystems: the rest, tty layer and serial drivers

STALE716d

5 messages, 3 authors, 2024-08-19 · open the first message on its own page

[PATCH net-next 1/2] tty: Add N_TASHTALK line discipline for TashTalk Localtalk serial driver

From: Rodolfo Zitellini <hidden>
Date: 2024-08-17 09:36:12

This is the patch for the line discipline

Signed-off-by: Rodolfo Zitellini <redacted>

---
 include/uapi/linux/tty.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/tty.h b/include/uapi/linux/tty.h
index 68aeae2addec..bac4c0af67e6 100644
--- a/include/uapi/linux/tty.h
+++ b/include/uapi/linux/tty.h
@@ -39,8 +39,9 @@
 #define N_MCTP		28	/* MCTP-over-serial */
 #define N_DEVELOPMENT	29	/* Manual out-of-tree testing */
 #define N_CAN327	30	/* ELM327 based OBD-II interfaces */
+#define N_TASHTALK	31	/* TashTalk LocalTalk driver */
 
 /* Always the newest line discipline + 1 */
-#define NR_LDISCS	31
+#define NR_LDISCS	32
 
 #endif /* _UAPI_LINUX_TTY_H */
-- 
2.34.1

Re: [PATCH net-next 1/2] tty: Add N_TASHTALK line discipline for TashTalk Localtalk serial driver

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2024-08-17 11:03:54

On Sat, Aug 17, 2024 at 11:32:58AM +0200, Rodolfo Zitellini wrote:
This is the patch for the line discipline
Please look at the kernel documentation for best how to write changelog
texts.  This needs a bit of work.

thanks,

greg k-h

Re: [PATCH net-next 1/2] tty: Add N_TASHTALK line discipline for TashTalk Localtalk serial driver

From: Rodolfo Zitellini <hidden>
Date: 2024-08-17 13:15:35

Please look at the kernel documentation for best how to write changelog
texts.  This needs a bit of work.
Hi Greg,
thanks for your review! I will absolutely improve the commit messages on both patches in the next version of the series.

Kind Regards,
Rodolfo

Re: [PATCH net-next 1/2] tty: Add N_TASHTALK line discipline for TashTalk Localtalk serial driver

From: Jiri Slaby <jirislaby@kernel.org>
Date: 2024-08-19 05:16:38

Where is 2/2?

It cannot be seen:
https://lore.kernel.org/all/20240817093258.9220-1-rwz@xhero.org/#r

On 17. 08. 24, 11:32, Rodolfo Zitellini wrote:
quoted hunk
This is the patch for the line discipline

Signed-off-by: Rodolfo Zitellini <redacted>

---
  include/uapi/linux/tty.h | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/tty.h b/include/uapi/linux/tty.h
index 68aeae2addec..bac4c0af67e6 100644
--- a/include/uapi/linux/tty.h
+++ b/include/uapi/linux/tty.h
@@ -39,8 +39,9 @@
  #define N_MCTP		28	/* MCTP-over-serial */
  #define N_DEVELOPMENT	29	/* Manual out-of-tree testing */
  #define N_CAN327	30	/* ELM327 based OBD-II interfaces */
+#define N_TASHTALK	31	/* TashTalk LocalTalk driver */
  
  /* Always the newest line discipline + 1 */
-#define NR_LDISCS	31
+#define NR_LDISCS	32
  
  #endif /* _UAPI_LINUX_TTY_H */
-- 
js

Re: [PATCH net-next 1/2] tty: Add N_TASHTALK line discipline for TashTalk Localtalk serial driver

From: Jiri Slaby <jirislaby@kernel.org>
Date: 2024-08-19 05:32:52

On 19. 08. 24, 7:16, Jiri Slaby wrote:
Where is 2/2?

It cannot be seen:
https://lore.kernel.org/all/20240817093258.9220-1-rwz@xhero.org/#r
It's a separate [off-list ref]. Please fix 
threading when sending next time.

-- 
js
suse labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help