# Re: \[PATCH net-next v5 4/7\] net: stmmac: Support a generic PCS field in mac\_device\_info

- From: Andrew Lunn \<andrew@lunn.ch\>
- Date: 2024-03-04 13:43:00 
- List: netdev
- Page: https://ratatoskr.run/netdev/2024/03/8844008
- Thread: https://ratatoskr.run/netdev/2024/03/8843951/t.md

```text
On Fri, Mar 01, 2024 at 04:35:01PM +0100, Romain Gantois wrote:
> Global stmmac support for early initialization of PCS devices requires a
> generic PCS reference that can be passed to phylink_pcs_pre_init().
> Currently, the mac_device_info struct contains only one PCS field, which is
> specific to the Lynx model.
> 
> As PCS models are hardware-specific, it is more appropriate to have a
> generic PCS field in the mac_device_info struct.
> 
> Refactor the lynx_pcs field into a generic phylink_pcs field.
> 
> Signed-off-by: Romain Gantois <romain.gantois@bootlin.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
```
