# Re: \[PATCH net-next v5 3/7\] net: stmmac: don't rely on lynx\_pcs presence to check for a PHY

- From: Andrew Lunn \<andrew@lunn.ch\>
- Date: 2024-03-04 13:41:26 
- List: netdev
- Page: https://ratatoskr.run/netdev/2024/03/8844007
- Thread: https://ratatoskr.run/netdev/2024/03/8843951/t.md

```text
On Fri, Mar 01, 2024 at 04:35:00PM +0100, Romain Gantois wrote:
> From: Maxime Chevallier <maxime.chevallier@bootlin.com>
> 
> When initializing attached PHYs, there are some cases where we don't expect
> any PHY to be connected. The logic uses conditions based on various local
> PCS configuration, but also calls-in phylink_expects_phy() via
> stmmac_init_phy(), which is enough to ensure we don't try to initialize a
> PHY when using a Lynx PCS, as long as we have the phy_interface set to a
> 802.3z mode and are using inband negociation.
> 
> Drop the lynx check, making the stmmac generic code more pcs_lynx-agnostic.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> [rgantois: commit log]
> Signed-off-by: Romain Gantois <romain.gantois@bootlin.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
```
