# Re: \[PATCH net-next v4 5/7\] net: stmmac: Signal to PHY/PCS drivers to keep RX clock on

- From: Jakub Kicinski \<kuba@kernel.org\>
- Date: 2024-02-21 19:15:28 
- List: netdev
- Page: https://ratatoskr.run/netdev/2024/02/8843669
- Thread: https://ratatoskr.run/netdev/2024/02/8843638/t.md

```text
On Wed, 21 Feb 2024 14:04:22 +0100 Romain Gantois wrote:
> There is a reocurring issue with stmmac controllers where the MAC fails to
> initialize its hardware if an RX clock signal isn't provided on the MAC/PHY
> link.
> 
> This causes issues when PHY or PCS devices either go into suspend while
> cutting the RX clock or do not bring the clock signal up early enough for
> the MAC to initialize successfully.
> 
> Set the mac_requires_rxc flag in the stmmac phylink config so that PHY/PCS
> drivers know to keep the RX clock up at all times.
> 
> Reported-by: Clark Wang <xiaoning.wang@nxp.com>
> Link: https://lore.kernel.org/all/20230202081559.3553637-1-xiaoning.wang@nxp.com/
> Reported-by: Clément Léger <redacted>
> Link: https://lore.kernel.org/linux-arm-kernel/20230116103926.276869-4-clement.leger@bootlin.com/
> Suggested-by: Russell King <linux@armlinux.org.uk>
> Signed-off-by: Romain Gantois <romain.gantois@bootlin.com>

breaks allmodconfig:

ERROR: modpost: "phylink_pcs_pre_init" [drivers/net/ethernet/stmicro/stmmac/stmmac.ko] undefined!
-- 
pw-bot: cr
```
