# RE: \[PATCH next 10/11\] block: Use a boolean expression instead of max() on booleans

- From: David Laight \<hidden\>
- Date: 2024-01-28 22:22:26 
- List: netdev
- Page: https://ratatoskr.run/netdev/2024/01/2474762
- Thread: https://ratatoskr.run/netdev/2024/01/2474688/t.md

```text
From: Linus Torvalds
> Sent: 28 January 2024 19:59
> 
> On Sun, 28 Jan 2024 at 11:36, David Laight [ref] wrote:
> >
> > However it generates:
> > error: comparison of constant â€˜0â€™ with boolean expression is always true [-Werror=bool-compare]
> > inside the signedness check that max() does unless a '+ 0' is added.
> 
> Please fix your locale. You have random garbage characters there,
> presumably because you have some incorrect locale setting somewhere in
> your toolchain.

Hmmmm blame gcc :-)
The error message displays as '0' but is e2:80:98 30 e2:80:99
I HATE UTF-8, it wouldn't be as bad if it were a bijection.

Lets see if adding 'LANG=C' in the shell script I use to
do kernel builds is enough.

I also managed to send parts 1 to 6 without deleting the RE:
(I have to cut&paste from wordpad into a 'reply-all' of the first
message I send. Work uses mimecast and it has started bouncing
my copy of every message I send to the lists.)

Maybe I should start using telnet to send raw SMTP :-)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
```
