# Re: \[PATCH net-next 04/10\] net: pcs: rzn1-miic: Convert to platform remove callback returning void

- From: Geert Uytterhoeven \<geert@linux-m68k.org\>
- Date: 2023-11-17 10:46:21 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/11/9339693
- Thread: https://ratatoskr.run/linux-renesas-soc/2023/11/8296092/t.md

```text
On Fri, Nov 17, 2023 at 11:00 AM Uwe Kleine-König
[ref] wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <redacted>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
```