# Re: \[PATCH net-next 08/10\] net: wwan: qcom\_bam\_dmux: Convert to platform remove callback returning void

- From: Sergey Ryazanov \<ryazanov.s.a@gmail.com\>
- Date: 2023-11-22 22:23:43 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/11/8296122
- Thread: https://ratatoskr.run/netdev/2023/11/8296092/t.md

```text
On 17.11.2023 11:59, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <redacted>

Reviewed-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
```