# Re: \[PATCH net-next 05/10\] net: sfp: Convert to platform remove callback returning void

- From: Russell King (Oracle) \<linux@armlinux.org.uk\>
- Date: 2023-11-17 12:28:22 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/11/11277227
- Thread: https://ratatoskr.run/netdev/2023/11/8296092/t.md

```text
On Fri, Nov 17, 2023 at 10:59:28AM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <redacted>

Reviewed-by: Russell King (Oracle) <redacted>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
```