[PATCH] net: ti: icssg-prueth: add PTP dependency

Subsystems: networking drivers, the rest

STALE1120d

4 messages, 4 authors, 2023-09-15 · open the first message on its own page

[PATCH] net: ti: icssg-prueth: add PTP dependency

From: Arnd Bergmann <arnd@kernel.org>
Date: 2023-09-12 18:55:20

From: Arnd Bergmann <arnd@arndb.de>

The driver can now use PTP if enabled but fails to link built-in
if PTP is a loadable module:

aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'

Add the usual dependency to avoid this.

Fixes: 186734c158865 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/ti/Kconfig | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
index 7f3e2e96c6e20..26ddc26fc7b8d 100644
--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -201,6 +201,7 @@ config TI_ICSSG_PRUETH
 
 config TI_ICSS_IEP
 	tristate "TI PRU ICSS IEP driver"
+	depends on PTP_1588_CLOCK_OPTIONAL
 	depends on TI_PRUSS
 	default TI_PRUSS
 	help
-- 
2.39.2

[PATCH] net: ti: icssg-prueth: add PTP dependency

From: MD Danish Anwar <danishanwar@ti.com>
Date: 2023-09-13 06:25:17

On 13/09/23 00:24, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@arndb.de>

The driver can now use PTP if enabled but fails to link built-in
if PTP is a loadable module:

aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'

Add the usual dependency to avoid this.

Fixes: 186734c158865 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
quoted hunk
---
 drivers/net/ethernet/ti/Kconfig | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
index 7f3e2e96c6e20..26ddc26fc7b8d 100644
--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -201,6 +201,7 @@ config TI_ICSSG_PRUETH
 
 config TI_ICSS_IEP
 	tristate "TI PRU ICSS IEP driver"
+	depends on PTP_1588_CLOCK_OPTIONAL
 	depends on TI_PRUSS
 	default TI_PRUSS
 	help
-- 
Thanks and Regards,
Danish

Re: [PATCH] net: ti: icssg-prueth: add PTP dependency

From: Jiri Pirko <jiri@resnulli.us>
Date: 2023-09-13 07:59:04

Tue, Sep 12, 2023 at 08:54:51PM CEST, arnd@kernel.org wrote:
From: Arnd Bergmann <arnd@arndb.de>

The driver can now use PTP if enabled but fails to link built-in
if PTP is a loadable module:

aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'

Add the usual dependency to avoid this.

Fixes: 186734c158865 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Jiri Pirko <redacted>

Re: [PATCH] net: ti: icssg-prueth: add PTP dependency

From: patchwork-bot+netdevbpf@kernel.org
Date: 2023-09-15 09:41:08

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller [off-list ref]:

On Tue, 12 Sep 2023 20:54:51 +0200 you wrote:
From: Arnd Bergmann <arnd@arndb.de>

The driver can now use PTP if enabled but fails to link built-in
if PTP is a loadable module:

aarch64-linux-ld: drivers/net/ethernet/ti/icssg/icss_iep.o: in function `icss_iep_get_ptp_clock_idx':
icss_iep.c:(.text+0x200): undefined reference to `ptp_clock_index'

[...]
Here is the summary with links:
  - net: ti: icssg-prueth: add PTP dependency
    https://git.kernel.org/netdev/net/c/a8f367f7e131

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help