# Re: \[PATCH\] net: phy: dp83867: Add support for hardware blinking LEDs

- From: Andrew Lunn \<andrew@lunn.ch\>
- Date: 2023-09-09 02:30:28 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/09/2328389
- Thread: https://ratatoskr.run/netdev/2023/09/2326366/t.md

```text
On Thu, Sep 07, 2023 at 10:47:31AM +0200, Sascha Hauer wrote:
> This implements the led_hw_* hooks to support hardware blinking LEDs on
> the DP83867 phy. The driver supports all LED modes that have a
> corresponding TRIGGER_NETDEV_* define. Error and collision do not have
> a TRIGGER_NETDEV_* define, so these modes are currently not supported.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
```