# Re: \[PATCH v2 20/28\] net: wan: Add framer framework support

- From: Andrew Lunn \<andrew@lunn.ch\>
- Date: 2023-08-01 09:57:16 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/08/2286947
- Thread: https://ratatoskr.run/netdev/2023/07/2280248/t.md

```text
> +int framer_pm_runtime_get(struct framer *framer)
> +{
> +	int ret;
> +
> +	if (!framer)
> +		return 0;

Can framer be a NULL pointer? This sort of test often covers up
bugs. So either let it dereference the NULL pointer and opps, or
return -EINVAL.

       Andrew
```
