On Mon, 2023-07-31 at 14:58 +0000, Leo Li wrote:

quoted

-----Original Message-----
From: Andrew Lunn <andrew@lunn.ch>
Sent: Saturday, July 29, 2023 3:14 AM
To: Leo Li <redacted>
Cc: Heiner Kallweit <hkallweit1@gmail.com>; Russell King
[off-list ref]; David S . Miller [off-list ref]; Jakub
Kicinski [off-list ref]; David Bauer [off-list ref];
netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Viorel Suman
[off-list ref]; Wei Fang [off-list ref]
Subject: Re: [PATCH v3 1/2] net: phy: at803x: fix the wol setting functions

On Fri, Jul 28, 2023 at 04:53:19PM -0500, Li Yang wrote:

quoted

In commit 7beecaf7d507 ("net: phy: at803x: improve the WOL feature"),
it seems not correct to use a wol_en bit in a 1588 Control Register
which is only available on AR8031/AR8033(share the same phy_id) to
determine if WoL is enabled.  Change it back to use
AT803X_INTR_ENABLE_WOL for determining the WoL status which is
applicable on all chips supporting wol. Also update the
at803x_set_wol() function to only update the 1588 register on chips having

it.

Do chips which do not have the 1588 register not have WoL? Or WoL
hardware is always enabled, but you still need to enable the interrupt.

Some of them do and some don't, which is removed in the other patch
from the series.  Since I don't find the register to enable it, I
guess it always enabled.

quoted

Have you tested on a range of PHY? It might be better to split this patch up a
bit. If it causes regressions, having smaller patches can make it easier to find
which change broken it.

No, I only have AR8035 to test with.  Changes for other chips are
according to the datasheet.  It would be good if others having the
hardware can test it too.

Adding Luo Jie for awareness.

@Luo Jie: do you have access to other chips handled by this driver
other then AR8035? could you please test this series:

https://patchwork.kernel.org/project/netdevbpf/list/?series=770734

?

Thanks!

Paolo