[PATCH -next] net: dm9051: Use PTR_ERR_OR_ZERO() to simplify code

Subsystems: networking drivers, the rest

STALE1116d

2 messages, 2 authors, 2023-08-16 · open the first message on its own page

[PATCH -next] net: dm9051: Use PTR_ERR_OR_ZERO() to simplify code

From: Ruan Jinjie <hidden>
Date: 2023-08-16 09:07:57

Return PTR_ERR_OR_ZERO() instead of return 0 or PTR_ERR() to
simplify code.

Signed-off-by: Ruan Jinjie <redacted>
---
 drivers/net/ethernet/davicom/dm9051.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/davicom/dm9051.c b/drivers/net/ethernet/davicom/dm9051.c
index 70728b2e5f18..2caaf1e9f42f 100644
--- a/drivers/net/ethernet/davicom/dm9051.c
+++ b/drivers/net/ethernet/davicom/dm9051.c
@@ -510,10 +510,7 @@ static int dm9051_map_init(struct spi_device *spi, struct board_info *db)
 
 	regconfigdmbulk.lock_arg = db;
 	db->regmap_dmbulk = devm_regmap_init_spi(db->spidev, &regconfigdmbulk);
-	if (IS_ERR(db->regmap_dmbulk))
-		return PTR_ERR(db->regmap_dmbulk);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(db->regmap_dmbulk);
 }
 
 static int dm9051_map_chipid(struct board_info *db)
-- 
2.34.1

Re: [PATCH -next] net: dm9051: Use PTR_ERR_OR_ZERO() to simplify code

From: Leon Romanovsky <leon@kernel.org>
Date: 2023-08-16 14:32:54

On Wed, Aug 16, 2023 at 05:07:22PM +0800, Ruan Jinjie wrote:
Return PTR_ERR_OR_ZERO() instead of return 0 or PTR_ERR() to
simplify code.

Signed-off-by: Ruan Jinjie <redacted>
---
 drivers/net/ethernet/davicom/dm9051.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Patch subject needs to be [PATCH net-next] ....

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help