# Re: \[PATCH v2 net\] gso: fix dodgy bit handling for GSO\_UDP\_L4

- From: Jason Wang \<hidden\>
- Date: 2023-07-14 03:59:49 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/07/2264876
- Thread: https://ratatoskr.run/netdev/2023/07/2264487/t.md

```text
On Fri, Jul 14, 2023 at 1:28 AM Yan Zhai [ref] wrote:
>
> Commit 1fd54773c267 ("udp: allow header check for dodgy GSO_UDP_L4
> packets.") checks DODGY bit for UDP, but for packets that can be fed
> directly to the device after gso_segs reset, it actually falls through
> to fragmentation:
>
> https://lore.kernel.org/all/CAJPywTKDdjtwkLVUW6LRA2FU912qcDmQOQGt2WaDo28KzYDg+A@mail.gmail.com/
>
> This change restores the expected behavior of GSO_UDP_L4 packets.
>
> Fixes: 1fd54773c267 ("udp: allow header check for dodgy GSO_UDP_L4 packets.")
> Suggested-by: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Signed-off-by: Yan Zhai <redacted>
>
> ---
> v2: dropped modifications to tcp/sctp on DODGY bit removal after
> validating gso_segs. Also moved the UDP header check into
> __udp_gso_segment (per Willem's suggestion).
>

Acked-by: Jason Wang <redacted>

Thanks

```
