# RE: \[Intel-wired-lan\] \[PATCH iwl-next v2 5/6\] ice: refactor ICE\_TC\_FLWR\_FIELD\_ENC\_OPTS

- From: Buvaneswaran, Sujai \<hidden\>
- Date: 2023-07-03 11:50:03 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/07/11265098
- Thread: https://ratatoskr.run/netdev/2023/06/11263005/t.md

```text
> -----Original Message-----
> From: Intel-wired-lan <redacted> On Behalf Of
> Marcin Szycik
> Sent: Wednesday, June 7, 2023 4:56 PM
> To: <redacted>
> Cc: jiri@resnulli.us; <redacted>; idosch@nvidia.com;
> Brandeburg, Jesse [ref];
> simon.horman@corigine.com; kuba@kernel.org; pabeni@redhat.com;
> davem@davemloft.net
> Subject: [Intel-wired-lan] [PATCH iwl-next v2 5/6] ice: refactor
> ICE_TC_FLWR_FIELD_ENC_OPTS
> 
> FLOW_DISSECTOR_KEY_ENC_OPTS can be used for multiple headers, but
> currently it is treated as GTP-exclusive in ice. Rename
> ICE_TC_FLWR_FIELD_ENC_OPTS to ICE_TC_FLWR_FIELD_GTP_OPTS and
> check for tunnel type earlier. After this refactor, it is easier to add new
> headers using FLOW_DISSECTOR_KEY_ENC_OPTS
> - instead of checking tunnel type in ice_tc_count_lkups() and
> ice_tc_fill_tunnel_outer(), it needs to be checked only once, in
> ice_parse_tunnel_attr().
> 
> Signed-off-by: Marcin Szycik <redacted>
> Reviewed-by: Simon Horman <redacted>
> ---
>  drivers/net/ethernet/intel/ice/ice_tc_lib.c | 10 +++++-----
> drivers/net/ethernet/intel/ice/ice_tc_lib.h |  2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
Tested-by: Sujai Buvaneswaran <redacted>
```
