# Re: \[PATCH net-next v2 10/17\] nvme: Use sendmsg(MSG\_SPLICE\_PAGES) rather then sendpage

- From: Willem de Bruijn \<willemdebruijn.kernel@gmail.com\>
- Date: 2023-06-19 11:47:08 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/06/2238540
- Thread: https://ratatoskr.run/netdev/2023/06/2237442/t.md

```text
David Howells wrote:
> Willem de Bruijn [ref] wrote:
> 
> >     struct bio_vec bvec;
> >     struct msghdr msg = { .msg_flags = MSG_SPLICE_PAGES | ... };
> > 
> >     ..
> > 
> >     bvec_set_virt
> >     iov_iter_bvec
> >     sock_sendmsg
> > 
> > is a frequent pattern. Does it make sense to define a wrapper? Same for bvec_set_page.
> 
> I dunno.  I'm trying to move towards aggregating multiple pages in a bvec
> before calling sendmsg if possible rather than doing it one page at a time,
> but it's easier and more obvious in some places than others.

Ok. I just wanted to have your opinion. Fine to leave as is.

Acked-by: Willem de Bruijn <willemb@google.com>

```