# Re: \[PATCH net-next 01/17\] net: Copy slab data for sendmsg(MSG\_SPLICE\_PAGES)

- From: David Howells \<dhowells@redhat.com\>
- Date: 2023-06-17 06:44:35 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/06/2237323
- Thread: https://ratatoskr.run/netdev/2023/06/2236827/t.md

```text
Simon Horman [ref] wrote:

> > +	cache = get_cpu_ptr(&skb_splice_frag_cache);
...
> > +	put_cpu_ptr(skb_splice_frag_cache);
> 
> Hi David,
> 
> I don't think it makes any difference at run-time.
> But to keep Sparse happy, perhaps this ought to be put_cpu_var()

Actually, the problem is a missing "&".  I think I should use put_cpu_ptr() to
match get_cpu_ptr().  It doesn't crash because the argument is ignored.

David

```