# Re: \[PATCH v2 2/2\] NFC: nxp-nci: Add pad supply voltage pvdd-supply

- From: Raymond Hackley \<hidden\>
- Date: 2023-06-09 20:52:59 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/06/2228275
- Thread: https://ratatoskr.run/linux-devicetree/2023/06/2227952/t.md

```text
Hi Mark,

On Friday, June 9th, 2023 at 7:34 PM, Mark Brown [ref] wrote:
 
> Specifically your driver should only ever call regulator_disable() to
> balance out regulator_enable() calls it made itself and it should know
> how many of those it has done. regulator_is_enabled() should only ever
> be used during probe if for some reason it is important to figure out if
> the device is already powered for startup, this should be very unusual.
> If something else enabled the regualtor then whatever did that needs to
> undo those enables, not another driver.

Thnak you for explanation. I should drop regulator_is_enabled() here since
it's misused.

Regards,
Raymond

```
