# Re: \[PATCH 2/2\] NFC: nxp-nci: Add pad supply voltage pvdd-supply

- From: Jakub Kicinski \<kuba@kernel.org\>
- Date: 2023-06-08 04:36:30 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/06/2225548
- Thread: https://ratatoskr.run/netdev/2023/06/2222379/t.md

```text
On Tue, 06 Jun 2023 07:25:55 +0000 Raymond Hackley wrote:
> +			if (r != -EPROBE_DEFER)
> +				dev_err(dev,
> +					"Failed to get regulator pvdd: %d\n",
> +					r);
> +			return r;

dev_err_probe() ?

> +	r = devm_add_action_or_reset(dev, nxp_nci_i2c_poweroff, phy);
> +	if (r < 0) {
> +		nfc_err(dev, "Failed to install poweroff handler: %d\n",
> +			r);
> +		nxp_nci_i2c_poweroff(phy);

The _or_reset() stands for "we'll call the action for you if we can't
add it". Don't call poweroff again.
-- 
pw-bot: cr
```
