# Re: \[PATCH v3 02/55\] iov\_iter: Remove last\_offset member

- From: Jeff Layton \<jlayton@kernel.org\>
- Date: 2023-03-31 19:16:32 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/03/246745
- Thread: https://ratatoskr.run/netdev/2023/03/246680/t.md

```text
On Fri, 2023-03-31 at 17:08 +0100, David Howells wrote:
> With the removal of ITER_PIPE, the last_offset member of struct iov_iter is
> no longer used, so remove it and un-unionise the remaining member.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Jens Axboe <axboe@kernel.dk>
> cc: Matthew Wilcox <willy@infradead.org>
> cc: Alexander Viro <viro@zeniv.linux.org.uk>
> cc: Jeff Layton <jlayton@kernel.org>
> cc: <redacted>
> cc: <redacted>
> cc: <redacted>
> cc: <redacted>
> ---
>  include/linux/uio.h | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/include/linux/uio.h b/include/linux/uio.h
> index 74598426edb4..2d8a70cb9b26 100644
> --- a/include/linux/uio.h
> +++ b/include/linux/uio.h
> @@ -43,10 +43,7 @@ struct iov_iter {
>  	bool nofault;
>  	bool data_source;
>  	bool user_backed;
> -	union {
> -		size_t iov_offset;
> -		int last_offset;
> -	};
> +	size_t iov_offset;
>  	size_t count;
>  	union {
>  		const struct iovec *iov;


Reviewed-by: Jeff Layton <jlayton@kernel.org>
```