# Re: \[RFC PATCH 23/28\] algif: Remove hash\_sendpage\*()

- From: Herbert Xu \<herbert@gondor.apana.org.au\>
- Date: 2023-03-17 02:41:59 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/03/245555
- Thread: https://ratatoskr.run/netdev/2023/03/245482/t.md

```text
David Howells [ref] wrote:
> Remove hash_sendpage*() and use hash_sendmsg() as the latter seems to just
> use the source pages directly anyway.

...

> -       if (!(flags & MSG_MORE)) {
> -               if (ctx->more)
> -                       err = crypto_ahash_finup(&ctx->req);
> -               else
> -                       err = crypto_ahash_digest(&ctx->req);

You've just removed the optimised path from user-space to
finup/digest.  You need to add them back to sendmsg if you
want to eliminate sendpage.

Cheers,
-- 
Email: Herbert Xu [ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
```
