# Re: \[PATCH\] net/net\_failover: fix queue exceeding warning

- From: Paolo Abeni \<pabeni@redhat.com\>
- Date: 2023-03-22 11:41:41 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/03/2143645
- Thread: https://ratatoskr.run/netdev/2023/03/2141603/t.md

```text
On Tue, 2023-03-21 at 10:29 +0800, Faicker Mo wrote:
> If the primary device queue number is bigger than the default 16,
> there is a warning about the queue exceeding when tx from the
> net_failover device.
> 
> Signed-off-by: Faicker Mo <redacted>

This looks like a fixes, so it should include at least a fixes tag.

More importantly a longer/clearer description of the issue is needed,
including the warning backtrace.

I think this warning:

https://elixir.bootlin.com/linux/latest/source/include/linux/netdevice.h#L3542

should not be ignored/silenced: it's telling that the running
configuration is not using a number of the available tx queues, which
is possibly not the thing you want.

Instead the failover device could use an higher number of tx queues and
eventually set real_num_tx_queues equal to the primary_dev when the
latter is enslaved.

Thanks,

Paolo



```
