# Re: \[PATCH v2 7/7\] tools/testing/selftests/bpf: replace open-coded 16 with TASK\_COMM\_LEN

- From: Steven Rostedt \<rostedt@goodmis.org\>
- Date: 2023-02-12 03:45:18 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/02/243432
- Thread: https://ratatoskr.run/netdev/2021/11/218444/t.md

```text
On Sun, 12 Feb 2023 11:38:52 +0800
Yafang Shao [ref] wrote:

> > Actually, there are cases that this needs to be a number, as b3bc8547d3be6
> > ("tracing: Have TRACE_DEFINE_ENUM affect trace event types as well") made
> > it update fields as well as the printk fmt.
> >  
> 
> It seems that TRACE_DEFINE_ENUM(TASK_COMM_LEN) in the trace events
> header files would be a better fix.

NACK! I much prefer the proper fix that adds the length.

-- Steve
```
