# Re: \[PATCH v2 1/6\] mm: introduce vma-\>vm\_flags modifier functions

- From: Matthew Wilcox \<willy@infradead.org\>
- Date: 2023-01-26 15:11:34 
- List: netdev
- Page: https://ratatoskr.run/netdev/2023/01/242440
- Thread: https://ratatoskr.run/linux-mm/2023/01/242241/t.md

```text
On Thu, Jan 26, 2023 at 04:50:59PM +0200, Mike Rapoport wrote:
> On Thu, Jan 26, 2023 at 11:17:09AM +0200, Mike Rapoport wrote:
> > On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote:
> > > +/* Use when VMA is not part of the VMA tree and needs no locking */
> > > +static inline void init_vm_flags(struct vm_area_struct *vma,
> > > +				 unsigned long flags)
> > 
> > I'd suggest to make it vm_flags_init() etc.
> 
> Thinking more about it, it will be even clearer to name these vma_flags_xyz()

Perhaps vma_VERB_flags()?

vma_init_flags()
vma_reset_flags()
vma_set_flags()
vma_clear_flags()
vma_mod_flags()

```
