[PATCH net-next] netlink: fix spelling mistake in dump size assert

Subsystems: devlink, netfilter, networking [general], the rest

STALE1322d LANDED

Landed in mainline as ec8f7d495b3d on 2023-01-25.

3 messages, 3 authors, 2023-01-25 · open the first message on its own page

[PATCH net-next] netlink: fix spelling mistake in dump size assert

From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-01-23 22:22:34

Commit 2c7bc10d0f7b ("netlink: add macro for checking dump ctx size")
misspelled the name of the assert as asset, missing an R.

Reported-by: Ido Schimmel <redacted>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: jiri@nvidia.com
CC: pablo@netfilter.org
CC: kadlec@netfilter.org
CC: fw@strlen.de
CC: johannes@sipsolutions.net
CC: ecree.xilinx@gmail.com
CC: netfilter-devel@vger.kernel.org
CC: coreteam@netfilter.org
---
 include/linux/netlink.h              | 2 +-
 net/devlink/devl_internal.h          | 2 +-
 net/netfilter/nf_conntrack_netlink.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/netlink.h b/include/linux/netlink.h
index 38f6334f408c..fa4d86da0ec7 100644
--- a/include/linux/netlink.h
+++ b/include/linux/netlink.h
@@ -263,7 +263,7 @@ struct netlink_callback {
 	};
 };
 
-#define NL_ASSET_DUMP_CTX_FITS(type_name)				\
+#define NL_ASSERT_DUMP_CTX_FITS(type_name)				\
 	BUILD_BUG_ON(sizeof(type_name) >				\
 		     sizeof_field(struct netlink_callback, ctx))
 
diff --git a/net/devlink/devl_internal.h b/net/devlink/devl_internal.h
index 1aa1a9549549..d0d889038138 100644
--- a/net/devlink/devl_internal.h
+++ b/net/devlink/devl_internal.h
@@ -135,7 +135,7 @@ int devlink_nl_instance_iter_dump(struct sk_buff *msg,
 static inline struct devlink_nl_dump_state *
 devlink_dump_state(struct netlink_callback *cb)
 {
-	NL_ASSET_DUMP_CTX_FITS(struct devlink_nl_dump_state);
+	NL_ASSERT_DUMP_CTX_FITS(struct devlink_nl_dump_state);
 
 	return (struct devlink_nl_dump_state *)cb->ctx;
 }
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index 90672e293e57..308fc0023c7e 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -3866,7 +3866,7 @@ static int __init ctnetlink_init(void)
 {
 	int ret;
 
-	NL_ASSET_DUMP_CTX_FITS(struct ctnetlink_list_dump_ctx);
+	NL_ASSERT_DUMP_CTX_FITS(struct ctnetlink_list_dump_ctx);
 
 	ret = nfnetlink_subsys_register(&ctnl_subsys);
 	if (ret < 0) {
-- 
2.39.1

Re: [PATCH net-next] netlink: fix spelling mistake in dump size assert

From: Ido Schimmel <hidden>
Date: 2023-01-24 07:38:07

On Mon, Jan 23, 2023 at 02:22:24PM -0800, Jakub Kicinski wrote:
Commit 2c7bc10d0f7b ("netlink: add macro for checking dump ctx size")
misspelled the name of the assert as asset, missing an R.

Reported-by: Ido Schimmel <redacted>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Thanks!

Re: [PATCH net-next] netlink: fix spelling mistake in dump size assert

From: patchwork-bot+netdevbpf@kernel.org
Date: 2023-01-25 01:00:20

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski [off-list ref]:

On Mon, 23 Jan 2023 14:22:24 -0800 you wrote:
Commit 2c7bc10d0f7b ("netlink: add macro for checking dump ctx size")
misspelled the name of the assert as asset, missing an R.

Reported-by: Ido Schimmel <redacted>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: jiri@nvidia.com
CC: pablo@netfilter.org
CC: kadlec@netfilter.org
CC: fw@strlen.de
CC: johannes@sipsolutions.net
CC: ecree.xilinx@gmail.com
CC: netfilter-devel@vger.kernel.org
CC: coreteam@netfilter.org

[...]
Here is the summary with links:
  - [net-next] netlink: fix spelling mistake in dump size assert
    https://git.kernel.org/netdev/net-next/c/ec8f7d495b3d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help