# Re: \[PATCH net\] lib: packing: fix shift wrapping in bit\_reverse()

- From: Vladimir Oltean \<olteanv@gmail.com\>
- Date: 2022-12-08 16:58:20 
- List: netdev
- Page: https://ratatoskr.run/netdev/2022/12/11247571
- Thread: https://ratatoskr.run/netdev/2022/12/11247341/t.md

```text
On Wed, Dec 07, 2022 at 07:41:28PM +0000, David Laight wrote:
> From: Dan Carpenter
> > Sent: 07 December 2022 12:21
> ....
> > > > -		new_val |= (bit << (width - i - 1));
> > > > +		if (val & BIT_ULL(1))
> > >
> > > hmm, why 1 and not i?
> > 
> > Because I'm a moron.  Let me resend.
> 
> Since we're not writing FORTRAN-IV why not use a variable
> name that is harder to confuse with 1?

How about 'k'?
```
