# RE: \[PATCH net\] lib: packing: fix shift wrapping in bit\_reverse()

- From: David Laight \<hidden\>
- Date: 2022-12-07 19:41:37 
- List: netdev
- Page: https://ratatoskr.run/netdev/2022/12/11247405
- Thread: https://ratatoskr.run/netdev/2022/12/11247341/t.md

```text
From: Dan Carpenter
> Sent: 07 December 2022 12:21
....
> > > -		new_val |= (bit << (width - i - 1));
> > > +		if (val & BIT_ULL(1))
> >
> > hmm, why 1 and not i?
> 
> Because I'm a moron.  Let me resend.

Since we're not writing FORTRAN-IV why not use a variable
name that is harder to confuse with 1?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

```
