[PATCH] ipw2x00: Remove some unused functions

Subsystems: intel pro/wireless 2100, 2200bg, 2915abg network connection support, the rest

STALE1337d LANDED

Landed in mainline as 5107778d0061 on 2022-12-08.

2 messages, 2 authors, 2022-12-08 · open the first message on its own page

[PATCH] ipw2x00: Remove some unused functions

From: Jiapeng Chong <hidden>
Date: 2022-11-29 06:24:29

Functions write_nic_auto_inc_address() and write_nic_dword_auto_inc() are
defined in the ipw2100.c file, but not called elsewhere, so remove these
unused functions.

drivers/net/wireless/intel/ipw2x00/ipw2100.c:427:20: warning: unused function 'write_nic_dword_auto_inc'.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3285
Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>
---
 drivers/net/wireless/intel/ipw2x00/ipw2100.c | 11 -----------
 1 file changed, 11 deletions(-)
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2100.c b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
index b0f23cf1a621..0812db8936f1 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
@@ -418,17 +418,6 @@ static inline void write_nic_byte(struct net_device *dev, u32 addr, u8 val)
 	write_register_byte(dev, IPW_REG_INDIRECT_ACCESS_DATA, val);
 }
 
-static inline void write_nic_auto_inc_address(struct net_device *dev, u32 addr)
-{
-	write_register(dev, IPW_REG_AUTOINCREMENT_ADDRESS,
-		       addr & IPW_REG_INDIRECT_ADDR_MASK);
-}
-
-static inline void write_nic_dword_auto_inc(struct net_device *dev, u32 val)
-{
-	write_register(dev, IPW_REG_AUTOINCREMENT_DATA, val);
-}
-
 static void write_nic_memory(struct net_device *dev, u32 addr, u32 len,
 				    const u8 * buf)
 {
-- 
2.20.1.7.g153144c

Re: wifi: ipw2x00: Remove some unused functions

From: Kalle Valo <kvalo@kernel.org>
Date: 2022-12-08 14:43:47

Jiapeng Chong [off-list ref] wrote:
Functions write_nic_auto_inc_address() and write_nic_dword_auto_inc() are
defined in the ipw2100.c file, but not called elsewhere, so remove these
unused functions.

drivers/net/wireless/intel/ipw2x00/ipw2100.c:427:20: warning: unused function 'write_nic_dword_auto_inc'.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3285
Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>
Patch applied to wireless-next.git, thanks.

5107778d0061 wifi: ipw2x00: Remove some unused functions

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20221129062407.83157-1-jiapeng.chong@linux.alibaba.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help