# Re: \[PATCH v2\] lib/test\_rhashtable: Remove set but unused variable 'insert\_retries'

- From: Herbert Xu \<herbert@gondor.apana.org.au\>
- Date: 2022-11-24 09:25:52 
- List: netdev
- Page: https://ratatoskr.run/netdev/2022/11/2019166
- Thread: https://ratatoskr.run/netdev/2022/11/2017337/t.md

```text
On Wed, Nov 23, 2022 at 05:37:02PM +0800, Jiapeng Chong wrote:
> Variable 'insert_retries' is not effectively used in the function, so
> delete it.
> 
> lib/test_rhashtable.c:437:18: warning: variable 'insert_retries' set but not used.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3242
> Reported-by: Abaci Robot <redacted>
> Signed-off-by: Jiapeng Chong <redacted>
> ---
> Changes in v2:
>   -The condition for modifying err is less than 0.
> 
>  lib/test_rhashtable.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Acked-by: Herbert Xu <herbert@gondor.apana.org.au>

Thanks,
-- 
Email: Herbert Xu [ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
```