# Re: \[PATCH\] lib/test\_rhashtable: Remove set but unused variable 'insert\_retries'

- From: Herbert Xu \<herbert@gondor.apana.org.au\>
- Date: 2022-11-23 08:20:40 
- List: netdev
- Page: https://ratatoskr.run/netdev/2022/11/2017214
- Thread: https://ratatoskr.run/netdev/2022/11/2017005/t.md

```text
On Wed, Nov 23, 2022 at 11:59:51AM +0800, Jiapeng Chong wrote:
>
> @@ -447,9 +447,7 @@ static int __init test_rhashtable_max(struct test_obj *array,
>  
>  		obj->value.id = i * 2;
>  		err = insert_retry(&ht, obj, test_rht_params);
> -		if (err > 0)
> -			insert_retries += err;
> -		else if (err)
> +		if (err)

This is wrong as you will now abort on a retried insertion.  You
should instead test for err < 0.

Thanks,
-- 
Email: Herbert Xu [ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
```