# Re: \[PATCH net\] eth: sp7021: drop free\_netdev() from spl2sw\_init\_netdev()

- From: Eric Dumazet \<hidden\>
- Date: 2022-11-09 16:32:07 
- List: netdev
- Page: https://ratatoskr.run/netdev/2022/11/11244189
- Thread: https://ratatoskr.run/netdev/2022/11/11244181/t.md

```text
On Wed, Nov 9, 2022 at 7:01 AM Wei Yongjun [ref] wrote:
>
> From: Wei Yongjun <redacted>
>
> It's not necessary to free netdev allocated with devm_alloc_etherdev()
> and using free_netdev() leads to double free.
>
> Fixes: fd3040b9394c ("net: ethernet: Add driver for Sunplus SP7021")
> Signed-off-by: Wei Yongjun <redacted>
>
> diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.c b/drivers/net/ethernet/sunplus/spl2sw_driver.c
> index 9be585237277..c499a14314f1 100644
> --- a/drivers/net/ethernet/sunplus/spl2sw_driver.c
> +++ b/drivers/net/ethernet/sunplus/spl2sw_driver.c
> @@ -287,7 +287,6 @@ static u32 spl2sw_init_netdev(struct platform_device *pdev, u8 *mac_addr,
>         if (ret) {
>                 dev_err(&pdev->dev, "Failed to register net device \"%s\"!\n",
>                         ndev->name);

If the following leads to a double free, how the previous use of
ndev->name would actually work ?

Please test your patch with CONFIG_KASAN=y

> -               free_netdev(ndev);
>                 *r_ndev = NULL;
>                 return ret;
>         }
> --
> 2.34.1
>
```
