# Re: \[PATCH net-next\] net: drop the weight argument from netif\_napi\_add

- From: Jakub Kicinski \<kuba@kernel.org\>
- Date: 2022-10-02 18:00:03 
- List: netdev
- Page: https://ratatoskr.run/netdev/2022/10/9358333
- Thread: https://ratatoskr.run/netdev/2022/09/11240699/t.md

```text
On Sun, 2 Oct 2022 10:24:27 -0700 Guenter Roeck wrote:
> On Tue, Sep 27, 2022 at 06:27:53AM -0700, Jakub Kicinski wrote:
> > We tell driver developers to always pass NAPI_POLL_WEIGHT
> > as the weight to netif_napi_add(). This may be confusing
> > to newcomers, drop the weight argument, those who really
> > need to tweak the weight can use netif_napi_add_weight().
> > 
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>  
> 
> That seems to have missed some (or at least one) file(s).
> 
> Building mips:cavium_octeon_defconfig ... failed
> --------------
> Error log:
> drivers/net/ethernet/cavium/octeon/octeon_mgmt.c: In function 'octeon_mgmt_probe':
> drivers/net/ethernet/cavium/octeon/octeon_mgmt.c:1399:9: error: too many arguments to function 'netif_napi_add'
>  1399 |         netif_napi_add(netdev, &p->napi, octeon_mgmt_napi_poll,
>       |         ^~~~~~~~~~~~~~
> In file included from include/linux/etherdevice.h:21,
>                  from drivers/net/ethernet/cavium/octeon/octeon_mgmt.c:11:
> include/linux/netdevice.h:2562:1: note: declared here
>  2562 | netif_napi_add(struct net_device *dev, struct napi_struct *napi,

Fix sent, sorry. I don't see any more problems grepping again now..
```
