# Re: \[PATCH net-next v2 07/12\] net: dpaa2-eth: use dev\_close/open instead of the internal functions

- From: Paolo Abeni \<pabeni@redhat.com\>
- Date: 2022-09-27 12:55:07 
- List: netdev
- Page: https://ratatoskr.run/netdev/2022/09/7819364
- Thread: https://ratatoskr.run/netdev/2022/09/7818710/t.md

```text
On Fri, 2022-09-23 at 18:45 +0300, Ioana Ciornei wrote:
> Instead of calling the internal functions which implement .ndo_stop and
> .ndo_open, we can simply call dev_close and dev_open, so that we keep
> the code cleaner.
> 
> Also, in the next patches we'll use the same APIs from other files
> without needing to export the internal functions.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>

This has the not so nice side effect that in case of dev_open() error,
the device will flip status after dpaa2_eth_setup_xdp(). We should try
to avoid that.

I think it's better if you export the helper instead (or even better,
do something more low level-cant-fail like stop the relevant h/w queue,
reconfigure, restart the h/w queue).

Cheers,

Paolo

```
