Re: [PATCH 1/1] net: fec: add initial XDP support
From: Andrew Lunn <andrew@lunn.ch>
Date: 2022-09-29 01:34:47
Also in:
imx, lkml
From: Andrew Lunn <andrew@lunn.ch>
Date: 2022-09-29 01:34:47
Also in:
imx, lkml
On Wed, Sep 28, 2022 at 10:25:09AM -0500, Shenwei Wang wrote:
This patch adds the initial XDP support to Freescale driver. It supports XDP_PASS, XDP_DROP and XDP_REDIRECT actions. Upcoming patches will add support for XDP_TX and Zero Copy features. This patch also optimizes the RX buffers by using the page pool, which uses one frame per page for easy management. In the future, it can be further improved to use two frames per page.
Please could you split this patch up. It is rather large and hard to review. I think you can first add support for the page pool, and then add XDP support, for example. I would be interesting to see how the page pool helps performance for normal traffic, since that is what most people use it for. And for a range of devices, since we need to make sure it does not cause any regressions for older devices. Andrew