# Re: \[PATCH net\] rhashtable: fix crash due to mm api change

- From: Florian Westphal \<fw@strlen.de\>
- Date: 2022-09-26 10:46:20 
- List: netdev
- Page: https://ratatoskr.run/netdev/2022/09/1945752
- Thread: https://ratatoskr.run/netdev/2022/09/1945294/t.md

```text
Herbert Xu [ref] wrote:
> Only in the case of kvzalloc.  We expect kzalloc to fail, that's
> why it gets NOWARN.  There is no sane reason for kvzalloc to fail
> so it should warn.

To me a WARN() only has one purpose:
It will get reported to mailing list and a developer can use that
to develop a patch/fix.

In memory allocation failure, there is no bug, so nothing to fix,
so WARN is useless.
```