# Re: \[PATCH net\] rhashtable: fix crash due to mm api change

- From: Florian Westphal \<fw@strlen.de\>
- Date: 2022-09-26 10:06:08 
- List: netdev
- Page: https://ratatoskr.run/netdev/2022/09/1945497
- Thread: https://ratatoskr.run/netdev/2022/09/1945294/t.md

```text
Herbert Xu [ref] wrote:
> On Mon, Sep 26, 2022 at 10:50:18AM +0200, Florian Westphal wrote:
> > Herbert Xu [ref] wrote:
> > > On Mon, Sep 26, 2022 at 10:31:39AM +0200, Florian Westphal wrote:
> > > >
> > > > This patch is partial revert of
> > > > commit 93f976b5190d ("lib/rhashtable: simplify bucket_table_alloc()"),
> > > > to avoid kvmalloc for ATOMIC case.
> > > 
> > > This patch should just be reverted.  If kvzalloc fails we should
> > > definitely know about it.
> > 
> > No idea what you mean, I am no mind reader.  Please consider
> > fixing this yourself, I am done with this crap.
> 
> I just meant that the patch quoted above should be completely
> reverted instead of partially reverted.

I don't understand that at all, since this means removal of
__GFP_NOWARN -- that makes no sense to me.
```