[net-next v2] selftests: Fix the if conditions of in test_extra_filter()

Subsystems: kernel selftest framework, networking [general], the rest

2 messages, 2 authors, 2022-09-27 · open the first message on its own page

[net-next v2] selftests: Fix the if conditions of in test_extra_filter()

From: Wang Yufen <hidden>
Date: 2022-09-23 06:42:03

The socket 2 bind the addr in use, bind should fail with EADDRINUSE. So
if bind success or errno != EADDRINUSE, testcase should be failed.

Fixes: 3ca8e4029969 ("soreuseport: BPF selection functional test")
Signed-off-by: Wang Yufen <redacted>
---
v1 -> v2: add a Fixes tag
 tools/testing/selftests/net/reuseport_bpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/reuseport_bpf.c b/tools/testing/selftests/net/reuseport_bpf.c
index 072d709c..65aea27 100644
--- a/tools/testing/selftests/net/reuseport_bpf.c
+++ b/tools/testing/selftests/net/reuseport_bpf.c
@@ -328,7 +328,7 @@ static void test_extra_filter(const struct test_params p)
 	if (bind(fd1, addr, sockaddr_size()))
 		error(1, errno, "failed to bind recv socket 1");
 
-	if (!bind(fd2, addr, sockaddr_size()) && errno != EADDRINUSE)
+	if (!bind(fd2, addr, sockaddr_size()) || errno != EADDRINUSE)
 		error(1, errno, "bind socket 2 should fail with EADDRINUSE");
 
 	free(addr);
-- 
1.8.3.1

Re: [net-next v2] selftests: Fix the if conditions of in test_extra_filter()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2022-09-27 09:10:19

Hello:

This patch was applied to netdev/net.git (master)
by Paolo Abeni [off-list ref]:

On Fri, 23 Sep 2022 15:02:37 +0800 you wrote:
The socket 2 bind the addr in use, bind should fail with EADDRINUSE. So
if bind success or errno != EADDRINUSE, testcase should be failed.

Fixes: 3ca8e4029969 ("soreuseport: BPF selection functional test")
Signed-off-by: Wang Yufen <redacted>
---
v1 -> v2: add a Fixes tag
 tools/testing/selftests/net/reuseport_bpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
  - [net-next,v2] selftests: Fix the if conditions of in test_extra_filter()
    https://git.kernel.org/netdev/net/c/bc7a31984489

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help