[PATCH v2 0/2] Mediatek ethernet patches for mt8188

Changes in v2:

v2:
1) Delete patch 'stmmac: dwmac-mediatek: add support for mt8188' as
Krzysztof Kozlowski's comment.
2) Update patch 'dt-bindings: net: mediatek-dwmac: add support for
mt8188' as Krzysztof Kozlowski's comment.
3) Add clk_csr property to fix warning ('clk_csr' was unexpected)
reported by running 'make dtbs_check'.

v1:
1) Add ethernet driver entry for mt8188.
2) Add binding document for ethernet on mt8188.

Add binding document for the ethernet on mt8188

Signed-off-by: Jianguo Zhang <redacted>
---
 .../devicetree/bindings/net/mediatek-dwmac.yaml        | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
index 61b2fb9e141b..eaf7e8d53432 100644
--- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml

@@ -20,6 +20,7 @@ select:
         enum:
           - mediatek,mt2712-gmac
           - mediatek,mt8195-gmac
+          - mediatek,mt8188-gmac
   required:
     - compatible
 

@@ -37,6 +38,11 @@ properties:
           - enum:
               - mediatek,mt8195-gmac
           - const: snps,dwmac-5.10a
+      - items:
+          - enum:
+              - mediatek,mt8188-gmac
+          - const: mediatek,mt8195-gmac
+          - const: snps,dwmac-5.10a
 
   clocks:
     minItems: 5

@@ -74,7 +80,7 @@ properties:
       or will round down. Range 0~31*170.
       For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550,
       or will round down. Range 0~31*550.
-      For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290,
+      For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290,
       or will round down. Range 0~31*290.
 
   mediatek,rx-delay-ps:

@@ -84,7 +90,7 @@ properties:
       or will round down. Range 0~31*170.
       For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550,
       or will round down. Range 0~31*550.
-      For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple
+      For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value need to be a multiple
       of 290, or will round down. Range 0~31*290.
 
   mediatek,rmii-rxc:

-- 
2.25.1

Add clk_csr property for snps,dwmac

Signed-off-by: Jianguo Zhang <redacted>
---
 Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 491597c02edf..8cff30a8125d 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml

@@ -288,6 +288,11 @@ properties:
       is supported. For example, this is used in case of SGMII and
       MAC2MAC connection.
 
+  clk_csr:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Frequency division factor for MDC clock.
+
   mdio:
     $ref: mdio.yaml#
     unevaluatedProperties: false

-- 
2.25.1

Il 20/09/22 10:36, Jianguo Zhang ha scritto:

Please keep the list ordered by name. MT8188 goes before 8195.

For MT8188/MT8195

For MT8188/MT8195

        of 290, or will round down. Range 0~31*290.
  
    mediatek,rmii-rxc:

On 20/09/2022 10:36, Jianguo Zhang wrote:

Add binding document for the ethernet on mt8188

Signed-off-by: Jianguo Zhang <redacted>

Please version your patches. git format-patch can do it for you.

Best regards,
Krzysztof

Dear AngeloGioacchino

	Thanks for your comment.

On Tue, 2022-09-20 at 15:22 +0200, AngeloGioacchino Del Regno wrote:

Il 20/09/22 10:36, Jianguo Zhang ha scritto:

quoted

Add binding document for the ethernet on mt8188

Signed-off-by: Jianguo Zhang <redacted>
---
  .../devicetree/bindings/net/mediatek-dwmac.yaml        | 10
++++++++--
  1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/mediatek-

dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-
dwmac.yaml
index 61b2fb9e141b..eaf7e8d53432 100644

--- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml

@@ -20,6 +20,7 @@ select:
          enum:
            - mediatek,mt2712-gmac

Please keep the list ordered by name. MT8188 goes before 8195.

We will adjust the order in next version patches.

quoted

            - mediatek,mt8195-gmac
+          - mediatek,mt8188-gmac
    required:
      - compatible
  

@@ -37,6 +38,11 @@ properties:
            - enum:
                - mediatek,mt8195-gmac
            - const: snps,dwmac-5.10a
+      - items:
+          - enum:
+              - mediatek,mt8188-gmac
+          - const: mediatek,mt8195-gmac
+          - const: snps,dwmac-5.10a
  
    clocks:
      minItems: 5

@@ -74,7 +80,7 @@ properties:
        or will round down. Range 0~31*170.
        For MT2712 RMII/MII interface, Allowed value need to be a

multiple of 550,
        or will round down. Range 0~31*550.
-      For MT8195 RGMII/RMII/MII interface, Allowed value need to
be a multiple of 290,
+      For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value
need to be a multiple of 290,

For MT8188/MT8195

We will adjust the order in next version patches.

quoted

        or will round down. Range 0~31*290.
  
    mediatek,rx-delay-ps:

@@ -84,7 +90,7 @@ properties:
        or will round down. Range 0~31*170.
        For MT2712 RMII/MII interface, Allowed value need to be a

multiple of 550,
        or will round down. Range 0~31*550.
-      For MT8195 RGMII/RMII/MII interface, Allowed value need to
be a multiple
+      For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value
need to be a multiple

For MT8188/MT8195

We will adjust the order in next version patches.

quoted

        of 290, or will round down. Range 0~31*290.
  
    mediatek,rmii-rxc:

BRS
Jianguo

Dear Krzysztof,

	Thanks for your comment.

On Tue, 2022-09-20 at 17:26 +0200, Krzysztof Kozlowski wrote:

On 20/09/2022 10:36, Jianguo Zhang wrote:

quoted

Add binding document for the ethernet on mt8188

Signed-off-by: Jianguo Zhang <redacted>

Please version your patches. git format-patch can do it for you.

We will add version info in next version patches.

Best regards,
Krzysztof

BRS
Jianguo