[PATCH v1] net/ethtool/tunnels: Check return value of nla_nest_start()
From: Li Zhong <hidden>
Date: 2022-09-18 01:55:23
Also in:
lkml
Subsystem:
networking [ethtool], networking [general], the rest · Maintainers:
Andrew Lunn, Jakub Kicinski, "David S. Miller", Eric Dumazet, Paolo Abeni, Linus Torvalds
Return value of nla_nest_start() could be null on error. We need to check it before we pass entry to nla_nest_end(). Signed-off-by: Li Zhong <redacted> --- net/ethtool/tunnels.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ethtool/tunnels.c b/net/ethtool/tunnels.c
index efde33536687..2d6b03a35dd9 100644
--- a/net/ethtool/tunnels.c
+++ b/net/ethtool/tunnels.c@@ -140,7 +140,7 @@ ethnl_tunnel_info_fill_reply(const struct ethnl_req_info *req_base, if (nla_put_be16(skb, ETHTOOL_A_TUNNEL_UDP_ENTRY_PORT, htons(IANA_VXLAN_UDP_PORT)) || nla_put_u32(skb, ETHTOOL_A_TUNNEL_UDP_ENTRY_TYPE, - ilog2(UDP_TUNNEL_TYPE_VXLAN))) + ilog2(UDP_TUNNEL_TYPE_VXLAN)) || !entry) goto err_cancel_entry; nla_nest_end(skb, entry);
--
2.25.1