[PATCH net-next] ethernet: 8390: remove unnecessary check of mem

Subsystems: 8390 network drivers [ne2000, 3c503, etc.], networking drivers, the rest

STALE1459d LANDED

Landed in mainline as 0e9804cff182 on 2022-09-29.

2 messages, 2 authors, 2022-09-29 · open the first message on its own page

[PATCH net-next] ethernet: 8390: remove unnecessary check of mem

From: Yang Yingliang <hidden>
Date: 2022-09-27 14:58:35

The 'mem' returned by platform_get_resource() has been checked in probe
function, so it is no need do this check in remove function.

Signed-off-by: Yang Yingliang <redacted>
---
 drivers/net/ethernet/8390/mcf8390.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/8390/mcf8390.c b/drivers/net/ethernet/8390/mcf8390.c
index 21047ae1bc3d..8a7918d33419 100644
--- a/drivers/net/ethernet/8390/mcf8390.c
+++ b/drivers/net/ethernet/8390/mcf8390.c
@@ -450,8 +450,7 @@ static int mcf8390_remove(struct platform_device *pdev)
 
 	unregister_netdev(dev);
 	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (mem)
-		release_mem_region(mem->start, resource_size(mem));
+	release_mem_region(mem->start, resource_size(mem));
 	free_netdev(dev);
 	return 0;
 }
-- 
2.25.1

Re: [PATCH net-next] ethernet: 8390: remove unnecessary check of mem

From: patchwork-bot+netdevbpf@kernel.org
Date: 2022-09-29 09:40:27

Hello:

This patch was applied to netdev/net-next.git (master)
by Paolo Abeni [off-list ref]:

On Tue, 27 Sep 2022 23:14:06 +0800 you wrote:
The 'mem' returned by platform_get_resource() has been checked in probe
function, so it is no need do this check in remove function.

Signed-off-by: Yang Yingliang <redacted>
---
 drivers/net/ethernet/8390/mcf8390.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Here is the summary with links:
  - [net-next] ethernet: 8390: remove unnecessary check of mem
    https://git.kernel.org/netdev/net-next/c/0e9804cff182

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help