[PATCH -next v2] nfp: Use skb_put_data() instead of skb_put/memcpy pair
Subsystems:
netronome ethernet drivers , networking drivers , the rest
1460d
LANDED
Landed in mainline as d49e265b66d9 on 2022-09-29.
4 messages,
3 authors,
2022-09-29 · open the first message on its own page
Use skb_put_data() instead of skb_put() and memcpy(), which is clear.
Signed-off-by: Shang XiaoJing <redacted>
---
changes in v2:
- no change
---
drivers/net/ethernet/netronome/nfp/nfd3/xsk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfd3/xsk.c b/drivers/net/ethernet/netronome/nfp/nfd3/xsk.c
index 65e243168765..5d9db8c2a5b4 100644
--- a/drivers/net/ethernet/netronome/nfp/nfd3/xsk.c
+++ b/drivers/net/ethernet/netronome/nfp/nfd3/xsk.c @@ -84,7 +84,7 @@ static void nfp_nfd3_xsk_rx_skb(struct nfp_net_rx_ring *rx_ring,
nfp_net_xsk_rx_drop ( r_vec , xrxbuf );
return ;
}
- memcpy ( skb_put ( skb , pkt_len ), xrxbuf -> xdp -> data , pkt_len ); + skb_put_data ( skb , xrxbuf -> xdp -> data , pkt_len );
skb -> mark = meta -> mark ;
skb_set_hash ( skb , meta -> hash , meta -> hash_type ); --
2.17.1
On 2022/9/27 22:18, Shang XiaoJing wrote: quoted hunk Use skb_put_data() instead of skb_put() and memcpy(), which is clear.
Signed-off-by: Shang XiaoJing <redacted>
---
changes in v2:
- no change
---
drivers/net/ethernet/netronome/nfp/nfd3/xsk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfd3/xsk.c b/drivers/net/ethernet/netronome/nfp/nfd3/xsk.c
index 65e243168765..5d9db8c2a5b4 100644
--- a/drivers/net/ethernet/netronome/nfp/nfd3/xsk.c
+++ b/drivers/net/ethernet/netronome/nfp/nfd3/xsk.c @@ -84,7 +84,7 @@ static void nfp_nfd3_xsk_rx_skb(struct nfp_net_rx_ring *rx_ring,
nfp_net_xsk_rx_drop ( r_vec , xrxbuf );
return ;
}
- memcpy ( skb_put ( skb , pkt_len ), xrxbuf -> xdp -> data , pkt_len ); + skb_put_data ( skb , xrxbuf -> xdp -> data , pkt_len );
skb -> mark = meta -> mark ;
skb_set_hash ( skb , meta -> hash , meta -> hash_type );
forgot to add the reviewed tag, sorry.
Reviewed-by: Simon Horman <redacted>
Thanks,
Shang XiaoJing
Hi Shang,
Thanks for your work.
On 2022-09-27 22:18:35 +0800, Shang XiaoJing wrote: Use skb_put_data() instead of skb_put() and memcpy(), which is clear.
Signed-off-by: Shang XiaoJing <redacted>
Reviewed-by: Niklas Söderlund <redacted>
quoted hunk ---
changes in v2:
- no change
---
drivers/net/ethernet/netronome/nfp/nfd3/xsk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfd3/xsk.c b/drivers/net/ethernet/netronome/nfp/nfd3/xsk.c
index 65e243168765..5d9db8c2a5b4 100644
--- a/drivers/net/ethernet/netronome/nfp/nfd3/xsk.c
+++ b/drivers/net/ethernet/netronome/nfp/nfd3/xsk.c @@ -84,7 +84,7 @@ static void nfp_nfd3_xsk_rx_skb(struct nfp_net_rx_ring *rx_ring,
nfp_net_xsk_rx_drop ( r_vec , xrxbuf );
return ;
}
- memcpy ( skb_put ( skb , pkt_len ), xrxbuf -> xdp -> data , pkt_len ); + skb_put_data ( skb , xrxbuf -> xdp -> data , pkt_len ); skb -> mark = meta -> mark ;
skb_set_hash ( skb , meta -> hash , meta -> hash_type );
- - 2.17.1
--
Kind Regards,
Niklas Söderlund
Hello:
This patch was applied to netdev/net-next.git (master)
by Paolo Abeni [off-list ref]:
On Tue, 27 Sep 2022 22:18:35 +0800 you wrote: Use skb_put_data() instead of skb_put() and memcpy(), which is clear.
Signed-off-by: Shang XiaoJing <redacted>
---
changes in v2:
- no change
[...]
Here is the summary with links:
- [-next,v2] nfp: Use skb_put_data() instead of skb_put/memcpy pair
https://git.kernel.org/netdev/net-next/c/d49e265b66d9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html