[PATCH net-next] net: vertexcom: mse102x: Silence no spi_device_id warnings

Subsystems: networking drivers, the rest

STALE1450d LANDED

Landed in mainline as 1bba1998bfd7 on 2022-09-26.

2 messages, 2 authors, 2022-09-26 · open the first message on its own page

[PATCH net-next] net: vertexcom: mse102x: Silence no spi_device_id warnings

From: Wei Yongjun <hidden>
Date: 2022-09-22 06:40:13

From: Wei Yongjun <redacted>

SPI devices use the spi_device_id for module autoloading even on
systems using device tree, after commit 5fa6863ba692 ("spi: Check
we have a spi_device_id for each DT compatible"), kernel warns as
follows since the spi_device_id is missing:

SPI driver mse102x has no spi_device_id for vertexcom,mse1021
SPI driver mse102x has no spi_device_id for vertexcom,mse1022

Add spi_device_id entries to silence the warnings, and ensure driver
module autoloading works.

Signed-off-by: Wei Yongjun <redacted>
diff --git a/drivers/net/ethernet/vertexcom/mse102x.c b/drivers/net/ethernet/vertexcom/mse102x.c
index 30a2f38491fe..aeed2a093e34 100644
--- a/drivers/net/ethernet/vertexcom/mse102x.c
+++ b/drivers/net/ethernet/vertexcom/mse102x.c
@@ -750,6 +750,13 @@ static const struct of_device_id mse102x_match_table[] = {
 };
 MODULE_DEVICE_TABLE(of, mse102x_match_table);
 
+static const struct spi_device_id mse102x_ids[] = {
+	{ "mse1021" },
+	{ "mse1022" },
+	{ }
+};
+MODULE_DEVICE_TABLE(spi, mse102x_ids);
+
 static struct spi_driver mse102x_driver = {
 	.driver = {
 		.name = DRV_NAME,
@@ -758,6 +765,7 @@ static struct spi_driver mse102x_driver = {
 	},
 	.probe = mse102x_probe_spi,
 	.remove = mse102x_remove_spi,
+	.id_table = mse102x_ids,
 };
 module_spi_driver(mse102x_driver);
 
-- 
2.34.1

Re: [PATCH net-next] net: vertexcom: mse102x: Silence no spi_device_id warnings

From: patchwork-bot+netdevbpf@kernel.org
Date: 2022-09-26 19:50:31

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski [off-list ref]:

On Thu, 22 Sep 2022 06:57:17 +0000 you wrote:
From: Wei Yongjun <redacted>

SPI devices use the spi_device_id for module autoloading even on
systems using device tree, after commit 5fa6863ba692 ("spi: Check
we have a spi_device_id for each DT compatible"), kernel warns as
follows since the spi_device_id is missing:

[...]
Here is the summary with links:
  - [net-next] net: vertexcom: mse102x: Silence no spi_device_id warnings
    https://git.kernel.org/netdev/net-next/c/1bba1998bfd7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help