# Re: \[RFCv8 PATCH net-next 02/55\] net: replace general features macroes with global netdev\_features variables

- From: shenjian (K) \<shenjian15@huawei.com\>
- Date: 2022-09-21 06:33:08 
- List: netdev
- Page: https://ratatoskr.run/netdev/2022/09/11240136
- Thread: https://ratatoskr.run/netdev/2022/09/11239803/t.md

```text


在 2022/9/21 4:12, Jakub Kicinski 写道:
> On Sun, 18 Sep 2022 09:42:43 +0000 Jian Shen wrote:
>> -#define NETIF_F_NEVER_CHANGE	(NETIF_F_VLAN_CHALLENGED | \
>> -				 NETIF_F_LLTX | NETIF_F_NETNS_LOCAL)
>> +#define NETIF_F_NEVER_CHANGE	netdev_never_change_features
> We shouldn't be changing all these defines here, because that breaks
> the build AFAIU.
ok, will keep them until remove the __NETIF_F(name) macro.


>   Can we not use the lowercase names going forward?
> .
ok
```
