linux-next: build warning after merge of the net-next tree

3 messages, 3 authors, 2022-08-25 · open the first message on its own page

linux-next: build warning after merge of the net-next tree

From: Stephen Rothwell <hidden>
Date: 2022-08-25 05:41:19

Hi all,

After merging the net-next tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/networking/kapi:26: net/core/skbuff.c:780: WARNING: Error in declarator or parameters
Invalid C declaration: Expecting "(" in parameters. [error at 19]
  void __fix_address kfree_skb_reason (struct sk_buff *skb, enum skb_drop_reason reason)
  -------------------^

Introduced by commit

  c205cc7534a9 ("net: skb: prevent the split of kfree_skb_reason() by gcc")

-- 
Cheers,
Stephen Rothwell

Re: [Internet]linux-next: build warning after merge of the net-next tree

From: imagedong (董梦龙) <hidden>
Date: 2022-08-25 08:05:38

Hello,

On 2022/8/25 13:41,“Stephen Rothwell”[off-list ref] write:
Hi all,

After merging the net-next tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/networking/kapi:26: net/core/skbuff.c:780: WARNING: Error in declarator or parameters
Invalid C declaration: Expecting "(" in parameters. [error at 19]
  void __fix_address kfree_skb_reason (struct sk_buff *skb, enum skb_drop_reason reason)
  -------------------^

Introduced by commit

  c205cc7534a9 ("net: skb: prevent the split of kfree_skb_reason() by gcc")
Yeah, I commited this patch. May I ask what command did you use to
produce this warning? I tried the following command, but not success:

  make V=2 SPHINXDIRS="networking" htmldocs

Hmm.......what does this warning means? Does it don't like this
function attribute?

Thanks!
Menglong Dong
-- 
Cheers,
Stephen Rothwell

Re: [Internet]linux-next: build warning after merge of the net-next tree

From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-08-25 17:42:17

On Thu, 25 Aug 2022 07:55:36 +0000 imagedong(董梦龙) wrote:
quoted
After merging the net-next tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/networking/kapi:26: net/core/skbuff.c:780: WARNING: Error in declarator or parameters
Invalid C declaration: Expecting "(" in parameters. [error at 19]
  void __fix_address kfree_skb_reason (struct sk_buff *skb, enum skb_drop_reason reason)
  -------------------^

Introduced by commit

  c205cc7534a9 ("net: skb: prevent the split of kfree_skb_reason() by gcc")
  
Yeah, I commited this patch. May I ask what command did you use to
produce this warning? I tried the following command, but not success:

  make V=2 SPHINXDIRS="networking" htmldocs

Hmm.......what does this warning means? Does it don't like this
function attribute?
It popped up for me on a clean build of

	make htmldocs

There's a lot of other warnings but you should see this one, too.

I think you need to add the new keyword to one of the tables in
Documentation/conf.py
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help