[PATCH linux-next] net: ethernet: ti:using the pm_runtime_resume_and_get to simplify the code Using pm_runtime_resume_and_get() to instade of pm_runtime_get_sync and pm_runtime_put_noidle.

Subsystems: networking drivers, the rest, ti ethernet switch driver (cpsw)

STALE1463d

2 messages, 2 authors, 2022-08-02 · open the first message on its own page

[PATCH linux-next] net: ethernet: ti:using the pm_runtime_resume_and_get to simplify the code Using pm_runtime_resume_and_get() to instade of pm_runtime_get_sync and pm_runtime_put_noidle.

From: <hidden>
Date: 2022-08-02 07:47:51

From: ye xingchen <redacted>

Reported-by: Zeal Robot <redacted>
Signed-off-by: ye xingchen <redacted>
---
 drivers/net/ethernet/ti/cpsw_priv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw_priv.c b/drivers/net/ethernet/ti/cpsw_priv.c
index 758295c898ac..abe5b65de415 100644
--- a/drivers/net/ethernet/ti/cpsw_priv.c
+++ b/drivers/net/ethernet/ti/cpsw_priv.c
@@ -1539,9 +1539,8 @@ static int cpsw_qos_setup_tc_block_cb(enum tc_setup_type type, void *type_data,
 	if (!tc_cls_can_offload_and_chain0(priv->ndev, type_data))
 		return -EOPNOTSUPP;
 
-	ret = pm_runtime_get_sync(priv->dev);
+	ret = pm_runtime_resume_and_get(priv->dev);
 	if (ret < 0) {
-		pm_runtime_put_noidle(priv->dev);
 		return ret;
 	}
 
-- 
2.25.1

Re: [PATCH linux-next] net: ethernet: ti:using the pm_runtime_resume_and_get to simplify the code Using pm_runtime_resume_and_get() to instade of pm_runtime_get_sync and pm_runtime_put_noidle.

From: Andrew Lunn <andrew@lunn.ch>
Date: 2022-08-02 13:35:58

On Tue, Aug 02, 2022 at 07:47:37AM +0000, cgel.zte@gmail.com wrote:
From: ye xingchen <redacted>

Reported-by: Zeal Robot <redacted>
Signed-off-by: ye xingchen <redacted>
It seems like 1/2 your subject line should be in the body of the patch
as the commit message.

   Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help