[PATCH linux-next] iavf: Remove the unused conditional statements

Subsystems: intel ethernet drivers, networking drivers, the rest

STALE1467d

2 messages, 2 authors, 2022-08-01 · open the first message on its own page

[PATCH linux-next] iavf: Remove the unused conditional statements

From: <hidden>
Date: 2022-08-01 02:28:06

From: ye xingchen <redacted>

Conditional statements have no effect to next process.So remove it.

Reported-by: Zeal Robot <redacted>
Signed-off-by: ye xingchen <redacted>
---
 drivers/net/ethernet/intel/iavf/iavf_main.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index e78c38d02432..b75e3e1119bd 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -2131,8 +2131,6 @@ iavf_set_vlan_offload_features(struct iavf_adapter *adapter,
 		vlan_ethertype = ETH_P_8021Q;
 	else if (prev_features & (NETIF_F_HW_VLAN_STAG_RX | NETIF_F_HW_VLAN_STAG_TX))
 		vlan_ethertype = ETH_P_8021AD;
-	else if (prev_features & (NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_CTAG_TX))
-		vlan_ethertype = ETH_P_8021Q;
 	else
 		vlan_ethertype = ETH_P_8021Q;
 
-- 
2.25.1

Re: [PATCH linux-next] iavf: Remove the unused conditional statements

From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-08-01 16:14:03

On Mon,  1 Aug 2022 02:27:54 +0000 cgel.zte@gmail.com wrote:
From: ye xingchen <redacted>

Conditional statements have no effect to next process.So remove it.
Nack, it's the default statement. Please fix the tool which makes you
send these patches. 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help