[PATCH] netfilter: ipvs: Use the bitmap API to allocate bitmaps

Subsystems: ipvs, netfilter, networking [general], the rest · Maintainers: Simon Horman, Julian Anastasov, Pablo Neira Ayuso, Florian Westphal, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

STALE1559d

4 messages, 4 authors, 2022-07-20 · open the first message on its own page

[PATCH] netfilter: ipvs: Use the bitmap API to allocate bitmaps

From: Christophe JAILLET <hidden>
Date: 2022-07-04 19:24:58

Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.

It is less verbose and it improves the semantic.

Signed-off-by: Christophe JAILLET <redacted>
---
 net/netfilter/ipvs/ip_vs_mh.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c
index da0280cec506..e3d7f5c879ce 100644
--- a/net/netfilter/ipvs/ip_vs_mh.c
+++ b/net/netfilter/ipvs/ip_vs_mh.c
@@ -174,8 +174,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s,
 		return 0;
 	}
 
-	table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE),
-			sizeof(unsigned long), GFP_KERNEL);
+	table = bitmap_zalloc(IP_VS_MH_TAB_SIZE, GFP_KERNEL);
 	if (!table)
 		return -ENOMEM;
 
@@ -227,7 +226,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s,
 	}
 
 out:
-	kfree(table);
+	bitmap_free(table);
 	return 0;
 }
 
-- 
2.34.1

Re: [PATCH] netfilter: ipvs: Use the bitmap API to allocate bitmaps

From: Julian Anastasov <ja@ssi.bg>
Date: 2022-07-05 10:21:50

	Hello,

On Mon, 4 Jul 2022, Christophe JAILLET wrote:
Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.

It is less verbose and it improves the semantic.

Signed-off-by: Christophe JAILLET <redacted>
	Looks good to me for -next! Thanks!

Acked-by: Julian Anastasov <ja@ssi.bg>
quoted hunk
---
 net/netfilter/ipvs/ip_vs_mh.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c
index da0280cec506..e3d7f5c879ce 100644
--- a/net/netfilter/ipvs/ip_vs_mh.c
+++ b/net/netfilter/ipvs/ip_vs_mh.c
@@ -174,8 +174,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s,
 		return 0;
 	}
 
-	table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE),
-			sizeof(unsigned long), GFP_KERNEL);
+	table = bitmap_zalloc(IP_VS_MH_TAB_SIZE, GFP_KERNEL);
 	if (!table)
 		return -ENOMEM;
 
@@ -227,7 +226,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s,
 	}
 
 out:
-	kfree(table);
+	bitmap_free(table);
 	return 0;
 }
 
-- 
2.34.1
Regards

--
Julian Anastasov [off-list ref]

Re: [PATCH] netfilter: ipvs: Use the bitmap API to allocate bitmaps

From: Simon Horman <horms@kernel.org>
Date: 2022-07-16 09:13:10

On Tue, Jul 05, 2022 at 01:05:54PM +0300, Julian Anastasov wrote:
	Hello,

On Mon, 4 Jul 2022, Christophe JAILLET wrote:
quoted
Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.

It is less verbose and it improves the semantic.

Signed-off-by: Christophe JAILLET <redacted>
	Looks good to me for -next! Thanks!

Acked-by: Julian Anastasov <ja@ssi.bg>
Acked-by: Simon Horman <horms@verge.net.au>

Re: [PATCH] netfilter: ipvs: Use the bitmap API to allocate bitmaps

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2022-07-20 22:58:11

On Mon, Jul 04, 2022 at 09:24:46PM +0200, Christophe JAILLET wrote:
Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.

It is less verbose and it improves the semantic.
Applied to nf-next, thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help