[PATCH] ptp: ocp: select CRC16 to fix build error

STALE1554d

2 messages, 2 authors, 2022-07-27 · open the first message on its own page

[PATCH] ptp: ocp: select CRC16 to fix build error

From: Randy Dunlap <rdunlap@infradead.org>
Date: 2022-07-27 01:12:39

ptp_ocp.c uses crc16(), so it should select CRC16 to
prevent a build error:

ERROR: modpost: "crc16" [drivers/ptp/ptp_ocp.ko] undefined!

Fixes: 3c3673bde50c ("ptp: ocp: Add firmware header checks")
Reported-by: kernel test robot <redacted>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Vadim Fedorenko <redacted>
Cc: Jonathan Lemon <redacted>
Cc: Richard Cochran <richardcochran@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <redacted>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
---
 drivers/ptp/Kconfig |    1 +
 1 file changed, 1 insertion(+)
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -176,6 +176,7 @@ config PTP_1588_CLOCK_OCP
 	depends on !S390
 	depends on COMMON_CLK
 	select NET_DEVLINK
+	select CRC16
 	help
 	  This driver adds support for an OpenCompute time card.
 

Re: [PATCH] ptp: ocp: select CRC16 to fix build error

From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-07-27 02:56:26

On Tue, 26 Jul 2022 18:12:13 -0700 Randy Dunlap wrote:
ptp_ocp.c uses crc16(), so it should select CRC16 to
prevent a build error:

ERROR: modpost: "crc16" [drivers/ptp/ptp_ocp.ko] undefined!

Fixes: 3c3673bde50c ("ptp: ocp: Add firmware header checks")
Reported-by: kernel test robot <redacted>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Vadim Fedorenko <redacted>
Cc: Jonathan Lemon <redacted>
Jonathan just posted this fix a few hours ago:

 https://lore.kernel.org/all/20220726220604.1339972-1-jonathan.lemon@gmail.com/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help